• Travis Cross's avatar
    Avoid buffer-overflow on short RTCP/SRTCP packets · aa4261d1
    Travis Cross 提交于
    In `srtp_unprotect_rtcp()` we are not validating that the packet
    length is as long as the minimum required.  This would cause
    `enc_octet_len` to underflow, which would cause us to try to decrypt
    data past the end of the packet in memory -- a buffer over-read and
    buffer overflow.
    
    In `srtp_protect_rtcp()`, we were similarly not validating the packet
    length.  Here we were also polluting the address of the SRTCP
    encrypted flag and index (the `trailer`), causing us to write one word
    to a bogus memory address before getting to the encryption where we
    would also overflow.
    
    In this commit we add checks to appropriately validate the RTCP/SRTCP
    packet lengths.
    
    `srtp_unprotect_rtcp_aead()` (but not protect) did correctly validate
    the packet length; this check would now be redundant as the check in
    `srtcp_unprotect_rtcp()` will also run first, so it has been removed.
    aa4261d1
名称
最后提交
最后更新
build 正在载入提交数据...
clients/flex 正在载入提交数据...
cmake_modules 正在载入提交数据...
conf 正在载入提交数据...
debian 正在载入提交数据...
docs 正在载入提交数据...
dtd 正在载入提交数据...
fscomm 正在载入提交数据...
htdocs 正在载入提交数据...
html5/verto 正在载入提交数据...
libs 正在载入提交数据...
scripts 正在载入提交数据...
src 正在载入提交数据...
support-d 正在载入提交数据...
w32 正在载入提交数据...
web 正在载入提交数据...
.gitattributes 正在载入提交数据...
.gitignore 正在载入提交数据...
Freeswitch.2005.unsupported.sln 正在载入提交数据...
Freeswitch.2008.express.unsupported.sln 正在载入提交数据...
Freeswitch.2008.sln.debug.bat 正在载入提交数据...
Freeswitch.2008.sln.release.bat 正在载入提交数据...
Freeswitch.2008.unsupported.sln 正在载入提交数据...
Freeswitch.2010.express.sln 正在载入提交数据...
Freeswitch.2010.sln 正在载入提交数据...
Freeswitch.2012.sln 正在载入提交数据...
Freeswitch.2012.sln.bat 正在载入提交数据...
INSTALL 正在载入提交数据...
Makefile.am 正在载入提交数据...
acinclude.m4 正在载入提交数据...
bootstrap.sh 正在载入提交数据...
cc.sh 正在载入提交数据...
cluecon.tmpl 正在载入提交数据...
cluecon2.tmpl 正在载入提交数据...
cluecon2_small.tmpl 正在载入提交数据...
cluecon_small.tmpl 正在载入提交数据...
configure.ac 正在载入提交数据...
devel-bootstrap.sh 正在载入提交数据...
erlang.spec 正在载入提交数据...
freeswitch-config-rayo.spec 正在载入提交数据...
freeswitch-sounds-en-us-callie.spec 正在载入提交数据...
freeswitch-sounds-music.spec 正在载入提交数据...
freeswitch-sounds-ru-RU-elena.spec 正在载入提交数据...
freeswitch-sounds-sv-se-jakob.spec 正在载入提交数据...
freeswitch.spec 正在载入提交数据...
swig_common.i 正在载入提交数据...