• Travis Cross's avatar
    Handle gcc's overzealous unused-result warning · b874048e
    Travis Cross 提交于
    Modern static analyzers warn when a variable is set but not used.  GCC
    warns when the result of a function marked as
    `__attribute__((warn_unused_result))` is not set to some variable,
    even when the function is cast to `(void)`, which is the recognized
    way of indicating the intent to ignore the result.  We treat all
    warnings as errors.
    
    The combination of behaviors here makes it difficult if we really
    don't care about the result of the function; the obvious workarounds
    are precluded.
    
    GCC's maintainers don't consider this to be a bug:
    
      Why do you think this is a bug?  warn_unused_result is for cases where
      "not checking the result is either a security problem or always a
      bug".
    
      https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509#c1
    
    GLIBC however marks functions like `read` and `write` with this
    attribute.  While it certainly in most cases is correct to act on
    their return value, in some cases we really just don't care.
    
    So when we see that we're building with GCC, and that we're building
    with all warnings enabled, we'll just pass -Wno-unused-result to
    disable the warning.
    
    ref: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=25509
    ref: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
    b874048e
configure.ac 62.3 KB